Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schematics): exclude environment imports for libraries #1213

Merged
merged 1 commit into from Jul 30, 2018
Merged

fix(schematics): exclude environment imports for libraries #1213

merged 1 commit into from Jul 30, 2018

Conversation

brandonroberts
Copy link
Member

Closes #1205, #1197

@coveralls
Copy link

coveralls commented Jul 29, 2018 •
edited

Coverage Status

Coverage increased (+0.2%) to 88.591% when pulling 58cb872 on fix-lib-environments into 4a0b580 on master.

timdeschryver
timdeschryver reviewed Jul 29, 2018
View reviewed changes
modules/schematics-core/utility/project.ts Outdated
) {
const project = getProject(host, options);

return project.projectType !== 'application';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be safer to check if the projectType is library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😴

@brandonroberts brandonroberts merged commit 541de02 into master Jul 30, 2018
@brandonroberts brandonroberts deleted the fix-lib-environments branch July 30, 2018 21:06
@brandonroberts brandonroberts mentioned this pull request Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandonroberts @coveralls @timdeschryver