Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreModule.forFeature should accept injection token #141

Closed
karptonite opened this issue Jul 20, 2017 · 3 comments
Closed

StoreModule.forFeature should accept injection token #141

karptonite opened this issue Jul 20, 2017 · 3 comments

Comments

@karptonite
Copy link
Contributor

See issue #116. The problem with AOT and reducers that are created by factories also exists for reducers imported in feature modules. However, the forFeature method lacks the handling for injector tokens that are present in forRoot. It seems like a similar approach should be added to forFeature.

@juliekoubova
Copy link

hello, is is there any chance this would get released soon? it's kind of blocking me 😢

@karptonite
Copy link
Contributor Author

@juliekoubova
Copy link

ok i should be able just "as any" my way until this gets released 😄
38b2f95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants