Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(selectors): Capture the type of a selectors projector #1920

Merged

Conversation

jasonhodges
Copy link
Contributor

  • supply a default projector type to MemoizedSelector

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently selectors projector functions are typed as 'any'

Closes #
#1908

What is the new behavior?

MemoizedSelector extended to have a third parameter that has a default projector function that utilizes Result as type.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- supply a default projector type to MemoizedSelector
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 5, 2019

Preview docs changes for 9c16e2c at https://previews.ngrx.io/pr1920-9c16e2c/

@brandonroberts brandonroberts merged commit 4e39cc1 into ngrx:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants