Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): Introduce @ngrx/schematics #631

Merged
merged 1 commit into from Dec 12, 2017
Merged

feat(lib): Introduce @ngrx/schematics #631

merged 1 commit into from Dec 12, 2017

Conversation

brandonroberts
Copy link
Member

Implements ngrx schematics, including:

  • Setting up the store root
  • Setting up a store feature
  • Generating an actions file
  • Generating a container component
  • Generating a reducer
  • Generating an effect
  • Generating an entity
  • Generating a "feature" (actions, effects, reducers)

Closes #53

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.4%) to 82.851% when pulling ebccc9e on schematics into 2fbcd24 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 87.718% when pulling 2b038f8 on schematics into 2fbcd24 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 92.429% when pulling caa2f0e on schematics into 2fbcd24 on master.

@@ -0,0 +1,54 @@
/**
* @license
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this copyright declaration intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the schematics were created from examples in the Angular schematics so I wasn't sure whether to remove them all or leave them.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 92.429% when pulling b6201ae on schematics into b7a554a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 92.429% when pulling 330dc30 on schematics into b7a554a on master.

@peterbsmyth
Copy link

@brandonroberts This is a big feature for the community. It might be helpful for your sanity to get assistance. Contributors are contributors. So you can let me and the rest of us know what you need, I'm happy to help. schematics is going to be life changing for my company! cc: @zoitsa

@brandonroberts
Copy link
Member Author

@peterbsmith2 I'm glad you're excited about schematics! The initial work in this PR is pretty much done pending review. What I'd like to do is get this reviewed and merged in so we can generate some nightly builds and get some people from the community to use it and provide feedback before it's published as official.

If you have anything you'd specifically like to see besides what's listed in the PR, add it to #53.

@MikeRyanDev
Copy link
Member

This is looking good to me so far. Are we waiting for the tests to turn green before removing the WIP?

@brandonroberts
Copy link
Member Author

I'll go ahead and remove the WIP and get the build green so we can merge it.

@brandonroberts brandonroberts changed the title WIP feat(lib): Introduce @ngrx/schematics feat(lib): Introduce @ngrx/schematics Dec 12, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 92.504% when pulling e26cacf on schematics into 561542c on master.

@brandonroberts
Copy link
Member Author

This is ready to land @MikeRyanDev

@MikeRyanDev MikeRyanDev merged commit 1837dba into master Dec 12, 2017
@MikeRyanDev MikeRyanDev deleted the schematics branch December 12, 2017 19:31
@sharikovvladislav
Copy link
Contributor

Awesome!!!!1

@peterbsmyth
Copy link

@brandonroberts I will want to tinker with this on nightly-builds. You can let me know the best way to get that start. I can be available for any cooperation you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants