-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal migrate code from gtkmm to ImGui #306
Comments
I'm not in favor at this time. Can imGui display popup windows like we use for protocol analyzers, etc? GTK for external UI chrome makes sense, it's separate from the waveform rendering and doesn't have to be super fast. It seems like it might be a viable solution for the WaveformArea overlays, but most of that isn't performance critical anyway. For the most part, text isn't a bottleneck in performance since not much is on screen at a time. Broken fullscreen is an issue but I don't think it's worth switching UI toolkits to fix. gtkmm has pre-existing installers and packaging, why would we build it ourselves? And if we use prebuilt binary DLL/SO packages without modifying it, LGPL vs permissive license is of no consequence. |
ImGui support popup window of course (including dialog ...) and tons of things much more advanced and easy to use than gtkmm (see ocornut/imgui#1453) |
We'll keep this issue open and think about it for the long term. I'm not ruling it out, but it would be a massive refactoring and I'm in no hurry. |
Yes there is no hurry and the advantage of ImGui is we can replace some dialog/popup/menu... from gtkmm to ImGui/ImPlot step by step without removing gtkmm (and keep gtkmm until the end if we see major improvement with ImGui/ImPlot especially with docking/multi-viewport branch) |
Closing this issue now that the ngscopeclient experiment is underway. We can file separate tickets for individual bugs/features in ngscopeclient as needed. |
The idea is to migrate from gtkmm to ImGui (https://github.com/ocornut/imgui)
For following reasons/known issues with gtkmm:
The text was updated successfully, but these errors were encountered: