Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use replay(1) to cache View references #137

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@nhaarman
Copy link
Owner

commented May 8, 2019

The replay operator internally caches N+1 elements instead of just
N, meaning it will keep a strong reference to the previous emitted
element. When this element references an Activity, leaks occur.

See ReactiveX/RxJava#6475.

Don't use replay(1) to cache View references
The `replay` operator internally caches N+1 elements instead of just
N, meaning it will keep a strong reference to the previous emitted
element. When this element references an Activity, leaks occur.

See ReactiveX/RxJava#6475.

@nhaarman nhaarman force-pushed the leakfix branch from c838a3a to 750b2a2 May 8, 2019

@nhaarman nhaarman merged commit 1dd826d into 1.0.x May 8, 2019

@nhaarman nhaarman deleted the leakfix branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.