Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke Scene.onStart after listener notification #163

Merged
merged 2 commits into from Mar 10, 2020

Conversation

@nhaarman
Copy link
Owner

nhaarman commented Mar 10, 2020

A Scene (A) that immediately causes another transition to
another Scene (B) when A's onStart method is invoked results
in the wrong order of scene notifications if the listener
invocation happens after starting the scene: First B is reported
and only then A.

Ensuring listener invocation happens before starting the Scene
resolves this issue.

@nhaarman nhaarman force-pushed the listenerinvocationsordering branch 3 times, most recently from 2f15b73 to 1499162 Mar 10, 2020
nhaarman added 2 commits Mar 10, 2020
A Scene (A) that _immediately_ causes another transition to
another Scene (B) when A's `onStart` method is invoked results
in the wrong order of scene notifications if the listener
invocation happens after starting the scene: First B is reported
and only then A.

Ensuring listener invocation happens before starting the Scene
resolves this issue.
A Scene (A) that _immediately_ causes another transition to
another Scene (B) when A's `onStart` method is invoked results
in the wrong order of scene notifications if the listener
invocation happens after starting the scene: First B is reported
and only then A.

Ensuring listener invocation happens before starting the Scene
resolves this issue.
@nhaarman nhaarman force-pushed the listenerinvocationsordering branch from 1499162 to cb62451 Mar 10, 2020
@nhaarman nhaarman merged commit b05bfbf into 1.x Mar 10, 2020
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@nhaarman nhaarman deleted the listenerinvocationsordering branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.