Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: group tooltip render properly with xAxis pointOnColumn option #260

Merged
merged 3 commits into from Feb 19, 2020
Merged

fix: group tooltip render properly with xAxis pointOnColumn option #260

merged 3 commits into from Feb 19, 2020

Conversation

jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

image

  • When using the xAxis pointOnColumn and tooltip grouped properties at the same time, the tooltip alignment line and point are not aligned as above.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jung-han jung-han added the NHN label Feb 14, 2020
junghwan-park
junghwan-park reviewed Feb 14, 2020
View reviewed changes
src/js/components/tooltips/groupTooltip.js
@@ -333,7 +334,7 @@ class GroupTooltip extends TooltipBase {
height
},
position: {
left: range.start,
left: range.start + this.tickInterval / 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

연산자 우선순위가 다르긴 하지만 수식인 경우 괄호를 넣는게 어떨까요~?
추후 수정에서 있을 지 모를 혼동을 막는게 좋으니까요

Copy link
Member Author

@jung-han jung-han Feb 14, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junghwan-park 괄호 작성시 prettier에서 제거됩니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗.. 그랬군요 ㅎㅎ 그럼 어쩔 수 없네요

junghwan-park
junghwan-park reviewed Feb 14, 2020
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료했습니다~!

@jinwoo-kim-nhn
Copy link
Contributor

리뷰완료했습니다. 수고하셨습니다

@jung-han jung-han merged commit 2755ee1 into master Feb 19, 2020
@jung-han jung-han deleted the fix/pointoncolumn-line branch February 19, 2020 01:19
@jung-han jung-han mentioned this pull request Mar 12, 2020
Merged
7 tasks
jung-han pushed a commit that referenced this pull request Mar 16, 2020
fix: add missing setting tickinterval on tooltip(#260) (#273)
07c9365 
* fix: add missing setting tickinterval on tooltip

* chore: fix typo

Logger -> Longer
@snyk-bot snyk-bot mentioned this pull request Apr 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinwoo-kim-nhn jinwoo-kim-nhn jinwoo-kim-nhn left review comments

@junghwan-park junghwan-park junghwan-park approved these changes

Assignees
No one assigned
Labels
NHN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jung-han @jinwoo-kim-nhn @junghwan-park