Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use core js #263

Merged
merged 2 commits into from Feb 24, 2020
Merged

chore: use core js #263

merged 2 commits into from Feb 24, 2020

Conversation

jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • remove babel-polyfill
  • use core-js directly
file name before size after size variance etc
tui-chart.js 1.61MB 1.65MB 40KB ↗️ include tui.code-snippet
tui-chart-polyfill.js 1.88MB 1.73MB 160KB ↘️ use core-js directly
tui-chart-all.js 2.09MB 1.82MB 270KB ↘️ decrease code-snippet size 70KB

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이견 없습니다! 고생 많았어요 ㅎㅎ

@jinwoo-kim-nhn
Copy link
Contributor

리뷰 완료 했습니다. animationFrame 관련해서는 core-js에 없나보네요.. 수고하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants