Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot click meridiem radio button of timepicker #90

Merged
merged 1 commit into from Sep 30, 2021

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed the problem that cannot click meridiem radio in the time picker.

As-is
2021-09-16-94712

To-Be
2021-09-16-20908


Thank you for your contribution to TOAST UI product. ๐ŸŽ‰ ๐Ÿ˜˜ โœจ

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒํ•ฉ๋‹ˆ๋‹ค.

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ์™„๋ฃŒํ•ฉ๋‹ˆ๋‹ค.

Copy link

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒ์ž…๋‹ˆ๋‹ค~! ํ…Œ์ŠคํŠธ๋Š” ๋”ฐ๋กœ ์ž‘์„ฑํ•˜๊ธฐ ์–ด๋ ค์šด ์ƒํ™ฉ์ธ๊ฐ€์š”? (์˜ˆ์ „ ์ฝ”๋“œ๋ผ ๋Š๋‚Œ์ƒ ๊ทธ๋Ÿด ๊ฒƒ ๊ฐ™๊ธดํ•˜๋„ค์š”)

@jajugoguma jajugoguma merged commit c1e1db4 into master Sep 30, 2021
@jajugoguma jajugoguma deleted the fix/not-click-meridiem-radio branch September 30, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants