Skip to content
Permalink
Browse files

fix: scroll sync does not work in last line (fix #411)

Editor need 18px margin in top and bottom by design guide.
So the margin of CodeMirror-sizer was set as 6px.

CodeMirror-sizer is element for calculating content size.
The sytle of CodeMirror-size is set dynamicly while update
display of CodeMirror.
Therefore, setting the margin on the CodeMrror-sizer is not
a good idea.

So if marign need to be set somewhere in CodeMirror,
CodeMirror-lines is more better choice.
  • Loading branch information...
Sohee Lee authored and sohee-lee7 committed Jul 2, 2019
1 parent 585c75f commit 7cdd9151082af2afcfaa1689d5a90f8a92101613
Showing with 3 additions and 7 deletions.
  1. +3 −7 src/css/tui-editor.css
@@ -83,7 +83,7 @@
}

.te-md-container .te-preview .tui-editor-contents {
padding-top: 11px;
padding-top: 8px;
}

.tui-editor .te-preview-style-tab>.te-editor,
@@ -177,8 +177,8 @@
}

.tui-editor-defaultUI .CodeMirror-lines {
padding-top: 13px;
padding-bottom: 13px;
padding-top: 18px;
padding-bottom: 18px;
}

.tui-editor-defaultUI .CodeMirror-line {
@@ -931,10 +931,6 @@ only screen and ( min-resolution: 2dppx) {
border: 1px solid #ebebeb;
}

.CodeMirror-sizer {
margin-top: 6px;
}

.CodeMirror .cm-header {
font-weight: bold;
color: inherit;

0 comments on commit 7cdd915

Please sign in to comment.
You can’t perform that action at this time.