Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popups through dropdown toolbar are misplaced #155

Closed
kyuwoo-choi opened this issue Apr 23, 2018 · 5 comments · Fixed by #158

Comments

@kyuwoo-choi
Copy link
Member

commented Apr 23, 2018

Version

1.1.0

Test Environment

all

Current Behavior

  1. shrink width and see the '...' button on toolbar
  2. click '...' button and see the dropdown toolbar
  3. click 'table' button and see that table popup is misplaced

image

image

Expected Behavior

the table popup should be placed under the table button.
I guess heading & color button are affected this issue too.

@kyuwoo-choi kyuwoo-choi added the Bug label Apr 23, 2018
@vpapadopou

This comment has been minimized.

Copy link

commented Apr 23, 2018

I've added a proposed solution in #151 that could also work for this case. In general, using the jquery to calculate and set fixed position for an item is not considered correct.

@kyuwoo-choi

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2018

@vpapadopou

I've seen the issue and It's a different one since 1.1.0

I'll check the issue again.
meanwhile, thanks for the solution. that'll help ppl to workaround.

kyuwoo-choi added a commit that referenced this issue May 3, 2018
@kyuwoo-choi kyuwoo-choi added this to the 1.1.1 milestone May 11, 2018
@galvarez421

This comment has been minimized.

Copy link

commented May 15, 2018

As of 1.1.1, I am still experiencing incorrect positioning for the headings dropdown/popup.

As described in #151, the issue appears to occur when the page is scrolled down (see images below).

After clicking headings button when page is scrolled to top:

scrolled-to-top

After clicking headings button when page is scrolled down:

scrolled-down

@kyuwoo-choi

This comment has been minimized.

Copy link
Member Author

commented May 16, 2018

Currently, popups are fixed position.

option 1

  • dismiss popups on scrolling

option 2

  • popups absolute position relative to toolbar element.
@kyuwoo-choi kyuwoo-choi reopened this May 16, 2018
@kyuwoo-choi

This comment has been minimized.

Copy link
Member Author

commented May 16, 2018

dedup #151

kyuwoo-choi added a commit that referenced this issue Jun 26, 2018
#151, #155) (#207)

* fix: popup position in toolbar

* fix: make popups be children of the toolbar

* refactor: code style

* fix: colorpicker absolute position as a child of the toolbar
@kyuwoo-choi kyuwoo-choi modified the milestones: 1.1.1, 1.2.4 Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.