Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert list in the table.(5MD) #321

Closed
ikan88 opened this issue Nov 8, 2018 · 3 comments

Comments

@ikan88
Copy link

ikan88 commented Nov 8, 2018

Hello. Thanks for your hardworking.
It would be great if it can insert list in the table.

@sohee-lee7

This comment has been minimized.

Copy link
Member

sohee-lee7 commented Dec 5, 2018

tui.editor follows GFM(https://github.github.com/gfm/#table), so can't insert list in the table.

@sohee-lee7 sohee-lee7 added the Question label Dec 5, 2018
@ikan88

This comment has been minimized.

Copy link
Author

ikan88 commented Dec 5, 2018

Thanks for answering my question.
Is there no way to insert list in the table until GFM specification change?

@cybaek

This comment has been minimized.

Copy link

cybaek commented Dec 10, 2018

@ikan88
Among the various specifications of markdown, there is no implementation that allows lists in the table.

@sohee-lee7 sohee-lee7 added the NHN label Feb 28, 2019
@sohee-lee7 sohee-lee7 added this to the 1.4.1 milestone Apr 17, 2019
@sohee-lee7 sohee-lee7 changed the title Insert list in the table. Insert list in the table.(5MD) Apr 17, 2019
kishorethecoder added a commit to kishorethecoder/tui.editor that referenced this issue Jul 11, 2019
* feat: implement to maintain tag inserted in markdown

* feat: implement to insert list in table

* refactor: reflect code review

* fix: key(up/down, enter, backspace, delete) operation in list of table (nhn#492)

* fix: up and down key does not work in list of table

* fix: do not block squire to merge td

When press backspace and delete in end of the td or empty td,
Squire merge TD or TR. So we block backspace and delete in these case.
But if TD or TR except when Squire merge block,
those code (blocking backspace and delete key event) is not needed.
So remove those code and fix Squire by handle TD and TR to exception
case.

* fix: can not remove list item when backspace occur first list item in table

* fix: div is generated when enter occur in empty li

* fix: delete key in the end of the list

* refactor: reflect code review

* chore: squire update (squire do not merge table)

* refactor: reflect code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.