Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code block is continue after line break in Wysiwyg (1MD) #408

Closed
sohee-lee7 opened this issue Feb 22, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@sohee-lee7
Copy link
Member

commented Feb 22, 2019

Version

v1.3.1

Test Environment

Chrome

Current Behavior

Insert inline code block in Wysiwyg and enter for line break.
But inline code block is continue.

image

Expected Behavior

Inline code block should be removed when enter key press.

Considerations

Position of cursor when enter key occur

  1. Not in table
    • in the start of the inline code block => Squire
    • in the middle of the inline code block => Squire
    • in the end of the inline code block => We should be remove inline code block style
  2. in table
    • Currently Squire process this case, but there are some problem about cursor access related #404

@sohee-lee7 sohee-lee7 added this to the 1.3.2 milestone Feb 22, 2019

@sohee-lee7 sohee-lee7 self-assigned this Feb 22, 2019

@sohee-lee7 sohee-lee7 changed the title Inline code block is continue after line break in Wysiwyg Inline code block is continue after line break in Wysiwyg (1MD) Feb 22, 2019

sohee-lee7 added a commit that referenced this issue Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.