Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong additional br (fix #200) #202

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
4 participants
@kyuwoo-choi
Copy link
Member

commented Jun 12, 2018

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

#200


Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

@kyuwoo-choi kyuwoo-choi changed the base branch from master to test/fix_e2e_glob Jun 14, 2018

@jinwoo-kim-nhn

This comment has been minimized.

Copy link

commented Jun 14, 2018

e2e ν…ŒμŠ€νŠΈ μ½”λ“œκ°€ μƒμ†Œν•˜λ„€μš” γ…Žγ…Ž
e2e ν…ŒμŠ€νŠΈκ°€ μΆ”κ°€λ˜μ–΄μ„œ 같은 ν…ŒμŠ€νŠΈλ₯Ό 2λ²ˆμ”© μž‘μ„±ν•˜λŠ” λŠλ‚Œμ΄ λ“œλ„€μš”;;
μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€. μ΄κ²¬μ—†μŠ΅λ‹ˆλ‹€.

const editor = Selector('.te-ww-container .te-editor');
const contentArea = editor.find('.tui-editor-contents');

this.blocks = contentArea.find('div,h1,h2,h3,h4,h5,h6,ul,ol,hr,table,pre');

This comment has been minimized.

Copy link
@seonim-ryu

seonim-ryu Jun 14, 2018

Member

p νƒœκ·Έλ„ μΆ”κ°€ν•΄μ•Όλ˜μ§€ μ•Šμ„κΉŒμš”?

This comment has been minimized.

Copy link
@kyuwoo-choi

kyuwoo-choi Jun 14, 2018

Author Member

pλŠ” 우리 μ—λ””ν„°μ—μ„œ 살아남아 μžˆμ§€ μ•Šμ€ νƒœκ·ΈλΌμ„œ μ œμ™Έν•©λ‹ˆλ‹€ :)
λͺ¨λ‘ div νƒœκ·Έλ‘œ μΉ˜ν™˜λ˜μ–΄μš”.

@seonim-ryu

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

[6/14] 리뷰 μ™„λ£Œν•˜μ˜€μŠ΅λ‹ˆλ‹€. ν…ŒμŠ€νŠΈμΉ΄νŽ˜ μΈμŠ€ν„΄μŠ€λͺ…이 μ‹ κΈ°ν•˜λ„€μš”γ…Ž

@shiren
Copy link
Member

left a comment

λ„€ μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.
E2E ν…ŒμŠ€νŠΈλŠ” μ‹œν–‰μ°©μ˜€λ₯Ό κ²ͺμœΌλ©΄μ„œ μ‘°κΈˆμ”© λ°©ν–₯을 κ°œμ„ ν•΄μ•Όκ² μ–΄μš”. μš” μ΄μŠˆλŠ” μœ λ‹›ν…ŒμŠ€νŠΈλ‘œ μΆ©λΆ„νžˆ 컀버가 κ°€λŠ₯ν•œ 뢀뢄인것도 κ°™κ΅¬μš”. κ²°κ΅­ μ •κ·œμ‹ 쑰금 μˆ˜μ •λœκ±° ν…ŒμŠ€νŠΈ ν•˜λŠ”κ²ƒμ΄λ‹ˆκΉŒμš”. 방금 이야기 λ‚˜λˆ„μ—ˆλ“― 계속 κ³ λ―Όν•˜κ³  μ΄μ•ΌκΈ°ν•΄λ΄μ•Όκ² μŠ΅λ‹ˆλ‹€.

@kyuwoo-choi kyuwoo-choi merged commit b40ee7d into test/fix_e2e_glob Jun 14, 2018

kyuwoo-choi added a commit that referenced this pull request Jun 14, 2018

@kyuwoo-choi kyuwoo-choi deleted the fix/wrong_additional_br branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.