Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export markdown-it instance without code highlight #304

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@floorish
Copy link
Contributor

commented Sep 27, 2018

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

The editor exports ToastUIEditor.markdownitHighlight so others can extend the markdown rendering behaviour. However the secondary markdown-it instance which is used in convertor.js: _markdownToHtml(markdown) is not exported. It was therefore impossible to extend the markdownToHtml behaviour.

This PR uses the same approach as used for ToastUIEditor.markdownitHighlight to export ToastUIEditor.markdownit as well.

@floorish floorish closed this Oct 3, 2018

@floorish floorish deleted the floorish:export-markdown-it branch Oct 3, 2018

@floorish floorish restored the floorish:export-markdown-it branch Oct 12, 2018

@floorish floorish reopened this Oct 12, 2018

@sohee-lee7

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

I think it's a good feature. I will merge after checking.

@sohee-lee7 sohee-lee7 added this to the 1.3.0 milestone Jan 3, 2019

@sohee-lee7 sohee-lee7 merged commit 4c9ba9b into nhn:master Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.