Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XSS in Viewer (fix #89) #90

Merged
merged 4 commits into from Feb 24, 2018

Conversation

@sean-nicholas
Copy link
Contributor

commented Feb 23, 2018

Please check if the PR fulfills these requirements

  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Initializes the HtmlSanitizer in the viewer to sanitize xss.

@sean-nicholas

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2018

I was not sure about the tests. Are there at the right place and should try to inject xss? Or should they just check if the htmlSanitizer is initialized?

@sean-nicholas sean-nicholas referenced this pull request Feb 23, 2018
@kyuwoo-choi kyuwoo-choi merged commit c374912 into nhn:master Feb 24, 2018
@kyuwoo-choi

This comment has been minimized.

Copy link
Member

commented Feb 24, 2018

You've done great 💯
Thank you @sean-nicholas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.