Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve datasource option #862

Merged
merged 23 commits into from Jan 15, 2020
Merged

feat: improve datasource option #862

merged 23 commits into from Jan 15, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jan 13, 2020

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • added ajax option

    • contentType: option to define request body type
    • headers: option to add headers
    • mimeType: option for parameter on calling overideMimeType function
    • serializer: option for custom serializer
  • added hideLoadingBar option to hide loading bar on communicating with server

  • added initParams to send user defined parameters to server when gets data

    // ...
    api: {
      readData: { 
        url: 'url', method: 'get', initParams: { a: 1 } 
      }
    }
  • added url option type. the function type is allowed as url option to define RESTful URI

    // ...
    api: {
      readData: { 
        url: () => `/url/${applicationId}`, method: 'get'
      }
    }
  • the class of gridAjax and serverSideDataProvider has been changed to functional based to remove ambiguous this context based in class and to make more concise and readable

  • cypress version update(3.8.1)


Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

@js87zz js87zz mentioned this pull request Jan 13, 2020
Copy link

@dongwoo-kim dongwoo-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ™„λ£Œ. κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~ 사싀상 거의 μ™„μ„±μ΄λ„€μš” γ…Žγ…Ž

Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œμž…λ‹ˆλ‹€! κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants