Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate tests from karma to jest #83

Merged
merged 4 commits into from Jun 23, 2021
Merged

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • remove karma-jasmine test environment
  • set jest test environment
  • tests migrate from jasmine to jest

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다 👏

README.md Outdated
- [🔧 Pull Request Steps](#-pull-request-steps)
- [Setup](#setup)
- [Develop](#develop)
- [Run dev server](#run-dev-server)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 컴포넌트에도 수정이 되었던데 여기서만 다시 첨언할게요.

"Run something" 이라고 하면 'XX를 실행해라' 라고 인식이 되어서 '개발서버를 실행하세요' 라는 느낌이 듭니다. 반면에 "Running something" 은 'XX 실행하기' 라는 의미이기 때문에 '개발 서버 실행하기', '테스트 실행하기' 같이 쓰일 수 있어서 문맥 제가 생각한 문맥 의도가 맞다면 "Running" 을 사용하는게 좋아보입니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 컴포넌트에 대해서 위 사항 반영하도록 하겠습니다.

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

Comment on lines 117 to 118
jest.useRealTimers();
jest.useFakeTimers();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest.useFakeTimers() 한번이면 되지 않나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 구문 삭제했습니다.

chore: remove unused variable
@jajugoguma jajugoguma merged commit ec3c697 into master Jun 23, 2021
@jajugoguma jajugoguma deleted the chore/karma-to-jest branch June 23, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants