New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate tests from karma to jest #83
Conversation
chore: remove karma-jasmine test environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰완료합니다 👏
README.md
Outdated
- [🔧 Pull Request Steps](#-pull-request-steps) | ||
- [Setup](#setup) | ||
- [Develop](#develop) | ||
- [Run dev server](#run-dev-server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 컴포넌트에도 수정이 되었던데 여기서만 다시 첨언할게요.
"Run something" 이라고 하면 'XX를 실행해라' 라고 인식이 되어서 '개발서버를 실행하세요' 라는 느낌이 듭니다. 반면에 "Running something" 은 'XX 실행하기' 라는 의미이기 때문에 '개발 서버 실행하기', '테스트 실행하기' 같이 쓰일 수 있어서 문맥 제가 생각한 문맥 의도가 맞다면 "Running" 을 사용하는게 좋아보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모든 컴포넌트에 대해서 위 사항 반영하도록 하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰완료합니다.
test/tree.spec.js
Outdated
jest.useRealTimers(); | ||
jest.useFakeTimers(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jest.useFakeTimers()
한번이면 되지 않나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 구문 삭제했습니다.
chore: remove unused variable
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨