Allow depending on Jekyll 4 #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nhoizey Do you have time to look at this PR? Being able to use this plugin in Jekyll 4 would be very handy. |
|
@contradictioned @ffes sorry for the delay, I made a change a little different to prevent automatic update when (if) Jekyll 5 is released some day… Thanks for the PR anyway |
|
@nhoizey Thanks, just updated my site and it works fine |
|
@ffes awesome, thanks for the feedback! |
|
Works here as well, thanks 👍 |
|
@contradictioned great news, thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C.f. #36.
I have just tried depending not only on the same major version but to any version later than Jekyll 3.6. Quick test shows, it works, despite the additional ignoring work described in #16.