Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aib better landing page #124

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Aib better landing page #124

merged 4 commits into from
Jun 22, 2024

Conversation

amaiaita
Copy link
Collaborator

@amaiaita amaiaita commented Jun 21, 2024 •
edited

Description

❓What: remove carousel and add tiles

🧠Why?: bad for accessibility

👨‍💻How?:

Checklist:

Have checked for the following:

  • The website still builds correctly, and you can view it using mkdocs serve.
  • There are no new "warnings" from mkdocs
  • Does your page follow the page template (or here in Markdown)? (need to make a new one specific to NHSE Data Science)
  • Spelling errors
  • Consistent capitalization
  • Consistent numbers
  • Material features incorrectly implemented: search for code blocks and markers (e.g. !!!).
  • Code snippets don't work
  • Images not working
  • Links not working

Where it was tested

  • Github Codespaces - 2-core, 4GB RAM, 32GB hard drive
  • devcontainer.json describes further settings

@amaiaita amaiaita linked an issue Jun 21, 2024 that may be closed by this pull request
consider whether a carousel is appropriate #54
Closed
@JRPearson500 JRPearson500 merged commit 6c0fcb2 into main Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRPearson500 JRPearson500 JRPearson500 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider whether a carousel is appropriate
2 participants
@amaiaita @JRPearson500