Use audited fork that allows reading encrypted attrs #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
force-pushed
the
audited-encryption
branch
from
3f09c7e
to
f97eb27
Compare
misaka
approved these changes
May 29, 2024
Audited automatically replaces entries in the `audited_changes` field on audits with `[FILTERED]` for attributes that are encrypted. This is designed to prevent leaking of sensitive information in `audited_changes` which is an unencrypted field. The downside to this is that the `audited_changes` field now provides less information about what the audit actually changed. To solve this, collectiveidea/audited#694 adds additional configuration attributes: - `Audited.filter_encrypted_attributes = false` disables the automatic replacement with `[FILTERED]` - `Audited.encrypt_audited_changes = true` encrypts the actual entire `audited_changes` field, ensuring that sensitive information isn't leaked See: - collectiveidea/audited#690 - collectiveidea/audited#694
tvararu
force-pushed
the
audited-encryption
branch
from
f97eb27
to
5a8bd35
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audited automatically replaces entries in the
audited_changesfield on audits with[FILTERED]for attributes that are encrypted. This is designed to prevent leaking of sensitive information inaudited_changeswhich is an unencrypted field.The downside to this is that the
audited_changesfield now provides less information about what the audit actually changed.To solve this, collectiveidea/audited#694 adds additional configuration attributes:
Audited.filter_encrypted_attributes = falsedisables the automatic replacement with[FILTERED]Audited.encrypt_audited_changes = trueencrypts the actual entireaudited_changesfield, ensuring that sensitive information isn't leakedSee:
Before - Fields filtered out and unreadable
Column unencrypted in database
After - Fields readable
Column encrypted