New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radios #19
Comments
What does nhsuk-radios class do? Not in version 2.0.0 of css |
Are there any plans to improve the radio component with conditional reveals? I'm thinking something similar to the Gov Design System: https://design-system.service.gov.uk/components/radios#conditionally-revealing-content Within the NHS BSA, we use this variant regularly across our range of services e.g. |
Latest info on radios in GDS design system backlog |
Hey @DouglasCaven what version of the frontend library are you using? This should be fixed in v5.2.0 |
Hi @AdamChrimes,
Thank you for a quick response.
Sound like a question for one of the developers so I’ve put the question to them and will get back to you.
I’m a UX designer and added this to the ticket because the developer who worked on the project at that has moved on.
What’s your email address?
Thanks,
Doug.
|
Thanks @DouglasCaven, when you find out, if you could feedback here rather than email so that others can benefit and also be able to answer (working in the open). |
Hi Adam,
I have spoken with the lead developer who advised that our project uses the webjar version 0.1.0 of the front end toolkit in SSECS (the project with the ‘conditional reveal’), and don't know which version of the Node.js FE toolkit that's generated from.
My guess (as a designer) that this wouldn’t be v5.2.0? What does the project need to do to ensure we are using v5.2.0?
Thanks,
Doug.
|
Hi @DouglasCaven I'm not familiar with the Webjar version, is this something custom NHSBSA have made for Java projects? If so, its vital that this Webjar version is kept up to date and in sync with the core NHS.UK frontend library. Custom language specific ports are not supported by the core team here at NHS Digital. Unfortunately I'm not familiar with this (and wasn't aware of it), so won't be best able to advise how to update it to use 5.2.0 of the NHS.UK frontend library - you may have to speak to the developers at NHSBSA about this. |
Hi Adam,
I’m waiting for a developer at the NHSBSA to get back to me and will put you in direct contact as they will be able to answer these questions.
Thanks,
Doug.
|
I've since spoken with one of the F/E developers at the NHSBSA who advised.... if we point to the latest release: https://github.com/nhsuk/nhsuk-frontend/releases and download the js/css files and add them to the project, should solve the issue. |
Running version 5.1.0, I have the following code: `
the first radio button reveals two sub radio buttons. but when you click on one of the sub radio buttons, the revealed section disappears. here is a recording to demonstrate: |
Hi Team, As result from a DAC audit, we have received the following feedback on the radios within NHS login: Reported issue: Some low vision users find it difficult to determine if an element can be activated if relying on a cursor change alone. A cursor change can be difficult to spot for low vision users, and some users find it helpful if additional highlighting is present. Suggested solution: an additional highlight could be added to interactive elements on hover. Is this something that is being considered for the radios? |
We'll see if we get further comments about this issue. So far, we've only seen it reported by DAC. There is some concern that adding hover states to all questions could cause new, different problems for other users eg. neurodivergent people finding it distracting. |
Use this issue to discuss radios in the NHS digital service manual
The text was updated successfully, but these errors were encountered: