diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 230993d9..2d72f5c9 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -5,3 +5,9 @@ # These owners will be the default owners for everything in the repo. * @jattasNI @rajsite + +# Specific content owners +/**/fv/** @jattasNI @fredvisser + +# Change files don't need explicit reviewers +/change diff --git a/change/@ni-eslint-config-angular-0fb9c127-1ff4-4c09-8790-86ea0527226c.json b/change/@ni-eslint-config-angular-0fb9c127-1ff4-4c09-8790-86ea0527226c.json new file mode 100644 index 00000000..9ff606e3 --- /dev/null +++ b/change/@ni-eslint-config-angular-0fb9c127-1ff4-4c09-8790-86ea0527226c.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "fv attribute list config", + "packageName": "@ni/eslint-config-angular", + "email": "1588923+rajsite@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/packages/eslint-config-angular/lib/ok/fv/ignore-attributes.js b/packages/eslint-config-angular/lib/ok/fv/ignore-attributes.js new file mode 100644 index 00000000..7838047f --- /dev/null +++ b/packages/eslint-config-angular/lib/ok/fv/ignore-attributes.js @@ -0,0 +1,4 @@ +// Fv angular attributes that SHOULD NOT be localized in production (i.e. enums) + +export const fvIgnoreAttributes = [ +]; diff --git a/packages/eslint-config-angular/lib/template-options.js b/packages/eslint-config-angular/lib/template-options.js index 80f5aa8a..c59aef80 100644 --- a/packages/eslint-config-angular/lib/template-options.js +++ b/packages/eslint-config-angular/lib/template-options.js @@ -10,6 +10,9 @@ // CSS selector style element[attribute] ignore entries // which can be used to scope attribute ignores to specific // elements. + +import { fvIgnoreAttributes } from './ok/fv/ignore-attributes.js'; + const ignoreAttributeSets = { web: [ 'accept', @@ -111,6 +114,10 @@ const ignoreAttributeSets = { // chat 'message-type' ], + ok: [ + // fv + ...fvIgnoreAttributes + ], systemlink: [ // gainsights telemetry 'data-telemetry',