service: Fix NI-SWITCH simulation errors #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
Test Results 30 files ± 0 30 suites ±0 25m 34s ⏱️ +23s Results for commit f949903. ± Comparison against base commit 1fdb753. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
dixonjoel
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Avoid
NISWITCH_ERROR_INVALID_RESOURCE_DESCRIPTORwhen settingsimulate=Trueforcreate_niswitch_session(s).Why should this Pull Request be merged?
Fixes a bug found while updating examples.
What testing has been done?
Ran updated unit tests.
Manually tested with updated examples.