Skip to content

Conversation

@Avinash2Suresh
Copy link
Contributor

@Avinash2Suresh Avinash2Suresh commented Dec 6, 2023

What does this Pull Request accomplish?

  • The Update Pin map and Clean up action steps are replaced with the "Update pin map" step.
  • Removed the teststand_pinmap.py file and an unused function in _helpers.py in the ../examples/nidcpower_source_dc_voltage/ directory.
  • Removed the FileGlobals.MeasurementLink.PinMapPath from the sequence.

Why should this Pull Request be merged?

Updates the NIDCPowerSourceDCVoltage.seq to use the "Update pin map" step - Task 2586977.

What testing has been done?

Ran the NI-DCPower sequence with the simulated NI-DCPower instrument by using the TestStand measurement client that is available in the main branch.

@jayaseelan-james
Copy link
Contributor

@Avinash2Suresh FYI, the latest INI changes are still in this branch.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Test Results

       30 files  ±0         30 suites  ±0   40m 24s ⏱️ + 2m 10s
     544 tests ±0       544 ✔️ ±0         0 💤 ±0  0 ±0 
13 300 runs  ±0  12 240 ✔️ ±0  1 060 💤 ±0  0 ±0 

Results for commit 10b2955. ± Comparison against base commit 8de6cf6.

@Avinash2Suresh Avinash2Suresh changed the title [Internal] examples: Update NI-DCPower TestStand sequence with the Update pin map custom step examples: Update NI-DCPower TestStand sequence with the Update pin map custom step Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants