Skip to content

Unify automated package checks #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

Unify automated package checks #117

wants to merge 29 commits into from

Conversation

@jfriedri-ni
Copy link
Collaborator

@jfriedri-ni jfriedri-ni commented Sep 3, 2025

What does this Pull Request accomplish?

TODO: Include high-level description of the changes in this pull request.

Why should this Pull Request be merged?

Fix #88

What testing has been done?

TODO: Detail what testing has been done to ensure this submission meets requirements.

@jfriedri-ni
First attempt at running checks on grpc_generator
7e831ec 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Try removing the sub-expression
cf6b374 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use format() to build the file path
4cef593 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Try GitHub discussions work around
922ca5e 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Move file-test to check_docs.yml
b2da8bc 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Try spamming every step with the conditional
22ca63f 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025 •
edited
Loading

Test Results

   66 files  ±0     66 suites  ±0   1m 44s ⏱️ ±0s
  184 tests ±0    184 ✅ ±0   0 💤 ±0  0 ❌ ±0 
1 824 runs  ±0  1 814 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 425e7d4. ± Comparison against base commit b9a221d.

♻️ This comment has been updated with latest results.

@jfriedri-ni
Remove same-dir prefix
acf5b3c 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Add package-basepath to outputs
b5d38c6 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Begin adding more package info key-value pairs
ea14da3 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
GITHUB_OUTPUT is not echo-able
4f03bf8 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Dumping the environment does not show the results
587b96a 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Separate parsing JSON form setting outputs
352e58d 
- bash does not accept hyphens in variable names

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Calculate the should_do_something variables
ecc6019 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Forget a 'then'
0183970 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use the output from the if-tests
ea2d7ad 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Debug proto_subpath
95d213d 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Quote test strings
f6b3f12 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Exercise using JSON null detection
5ea7661 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Debug proto_subpath
53005c9 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
jq returns null objects as {null}
b656619 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Try null JSON literals
830d723 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use JSON null literals
801f440 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use the docs directory to detect documentation artifacts
27b08b6 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use all keys in all JSON objects, update workflow files to use calcul…
c406cd1 
…ated package info

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use a string comparison for the output values
ef7266b 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Restore './' prefix to minimize diffs with main
53df7fe 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Let's try a GH emoji
2a82272 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Try using quotes to use GH emoji
15533c8 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Select 'basepath' as the spelling
425e7d4 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Copy link
Collaborator Author

jfriedri-ni commented Sep 5, 2025

See #120

@jfriedri-ni jfriedri-ni closed this Sep 5, 2025
@jfriedri-ni jfriedri-ni deleted the users/jfriedri/fix-88-with-no-special-case-packages branch September 5, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkeryan bkeryan Awaiting requested review from bkeryan bkeryan will be requested when the pull request is marked ready for review bkeryan is a code owner

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel will be requested when the pull request is marked ready for review dixonjoel is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make grpc_generator more consistent with the rest of the packages.

2 participants

@jfriedri-ni