Add conversion methods for Vector#54
Merged
Merged
Conversation
added 3 commits
August 9, 2025 14:36
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Contributor
jfriedri-ni
approved these changes
Aug 11, 2025
bkeryan
requested changes
Aug 11, 2025
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
approved these changes
Aug 11, 2025
bkeryan
left a comment
bkeryan
left a comment
Collaborator
There was a problem hiding this comment.
Approved with suggestions
added 4 commits
August 12, 2025 08:50
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add the
vector_to_protobufandvector_from_protobufmethods to a new filevector_conversion.py. These methods convert thevector_pb2.Vectorprotobuf type to theVectorpython type and vise versa.Add unit tests for
Vectortotest_ni_protobuf_types.py.Add new unit tests for vector conversion to
test_vector_conversion.pyRefactor conversion methods for
AttributeValueintoattribute_value_conversion.pyand update bothscalar_conversionandvector_conversionto use them.Why should this Pull Request be merged?
Implements AB#3218062
What testing has been done?
Unit tests, mypy, pyright, styleguide.