New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive architecture #49

Closed
sockeqwe opened this Issue Dec 7, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@sockeqwe
Contributor

sockeqwe commented Dec 7, 2015

Hi Nick, we have talked about the architecture of this app via hangouts a few weeks ago.

Finally, I was able to write down some of my thoughts on my blog. It was way more complex and tooked much longer than I have expected, but I do not really need to tell you that 😄

If you are still interested in hearing my point of view about software architecture on android I would like to ask you to read my blog post about the refactoring as I'm explaining some core aspects there (so I don't have to repeat myself here again).

Part 1: http://hannesdorfmann.com/android/plaid-refactored-1/
Part 2: http://hannesdorfmann.com/android/plaid-refactored-2/

If you really want to go the "truly reactive way" as described in my blog post I will do some code clean up and make a pull request. Otherwise, I don't mind because as already said the main goal was to write an blog post.

All libraries I have used are under Apache 2 license.

Last but not least I want to thank you for open sourcing this app. It's a truly inspiration and I have learned a lot about animations and UI / UX!

@nickbutcher

This comment has been minimized.

Show comment
Hide comment
@nickbutcher

nickbutcher Dec 8, 2015

Owner

Hi Hannes, I read and really enjoyed your blog posts. Thanks for taking the time to create and share them.

I'm reluctant to merge these changes because, as you pointed out, I'd like to keep the repo as accessible as possible so that the most users can learn these UI techniques. The goal of Plaid has never been to create the perfect app but to demonstrate UI concepts. I would be worried that a more complex architecture (while obviously advantageous) would damage that goal.

I would however be more than happy to point people to your fork. Let me know when you think it's in a good state & I'll update the readme.

Owner

nickbutcher commented Dec 8, 2015

Hi Hannes, I read and really enjoyed your blog posts. Thanks for taking the time to create and share them.

I'm reluctant to merge these changes because, as you pointed out, I'd like to keep the repo as accessible as possible so that the most users can learn these UI techniques. The goal of Plaid has never been to create the perfect app but to demonstrate UI concepts. I would be worried that a more complex architecture (while obviously advantageous) would damage that goal.

I would however be more than happy to point people to your fork. Let me know when you think it's in a good state & I'll update the readme.

@nickbutcher nickbutcher closed this Dec 8, 2015

@sockeqwe

This comment has been minimized.

Show comment
Hide comment
@sockeqwe

sockeqwe Dec 8, 2015

Contributor

That makes perfect sense and I have already expected this.

However, I don't think that I will invest more time on my fork.

Keep up you good work! Can't wait to install a final Plaid 1.0 version on my phone.

Contributor

sockeqwe commented Dec 8, 2015

That makes perfect sense and I have already expected this.

However, I don't think that I will invest more time on my fork.

Keep up you good work! Can't wait to install a final Plaid 1.0 version on my phone.

@Rainer-Lang

This comment has been minimized.

Show comment
Hide comment
@Rainer-Lang

Rainer-Lang Dec 8, 2015

@sockeqwe But your blog about Plaid and refactoring it isn't finished - hopefully?

Rainer-Lang commented Dec 8, 2015

@sockeqwe But your blog about Plaid and refactoring it isn't finished - hopefully?

@sockeqwe

This comment has been minimized.

Show comment
Hide comment
@sockeqwe

sockeqwe Dec 8, 2015

Contributor

@Rainer-Lang I will write one last part about testing the refactored app

Contributor

sockeqwe commented Dec 8, 2015

@Rainer-Lang I will write one last part about testing the refactored app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment