Simplify text input and improve backspace handling

Author: AMDmi3

src/Input.cpp

@@ -99,16 +99,15 @@ void Input::Update()
                 || (e.key.keysym.sym == SDLK_SPACE)) {
                char ch = (char)e.key.keysym.sym;
                ch = shift ? toupper(ch) : ch;
-               text.write(&ch, 1);
+               text += ch;
             }
             else if (e.key.keysym.sym == SDLK_LSHIFT
                      || e.key.keysym.sym == SDLK_RSHIFT) {
                shift = true;
             }
-            else if (e.key.keysym.sym == SDLK_BACKSPACE && text.tellp() > 0)	{
-               long pos = text.tellp();
-               if (pos > 0)
-                  text.seekp(pos - 1);
+            else if (e.key.keysym.sym == SDLK_BACKSPACE) {
+               if (!text.empty())
+                  text.erase(text.end() - 1);
             }
          }
          break;
@@ -248,7 +247,7 @@ void Input::OpenCharBuffer(int max)
 
    shift = false;
    maxchar = max;
-   text.str("");
+   text = "";
    textinput = true;
 }
 
@@ -268,5 +267,5 @@ void Input::CloseCharBuffer()
 //
 string Input::GetInput() const
 {
-   return text.str();
+   return text;
 }

src/Input.hpp

@@ -22,8 +22,6 @@
 
 #include "Platform.hpp"
 
-#include <sstream>
-
 // 
 // A singleton class to manage SDL input.
 //
@@ -60,7 +58,7 @@ class Input {
 
    bool shift;
    bool textinput;			// Is a character buffer open?
-   ostringstream text;	// Text read so far
+   string text;	// Text read so far
    int maxchar;			  	// Maximum number of characters to read
 
    // Record joystick state

src/Options.cpp

@@ -24,6 +24,7 @@
 #include "InterfaceSounds.hpp"
 
 #include <cassert>
+#include <sstream>
 
 const double Options::FADE_SPEED = 0.1;