Permalink
Commits on Oct 29, 2009
  1. Merge branch 'maint-1.6.2'

    * maint-1.6.2:
      library: don't list albums with multiple discs multiple times
    bebarino committed Oct 29, 2009
  2. Merge branch 'sb/album-multiple-discs' into maint-1.6.2

    * sb/album-multiple-discs:
      library: don't list albums with multiple discs multiple times
    bebarino committed Oct 29, 2009
  3. library: don't list albums with multiple discs multiple times

    If a user has a music directory where an album has multiple directories
    for each disc, we would wrongly list that album multiple times in the
    album view. This is because when we remove duplicate album listings, the
    differing paths lead us to believe the albums are not the same. Fix this
    by ignoring the path of the music files so when we remove the duplicates
    we are left with just one album instead of multiple ones.
    
    Fixes: #16368
    Tested-by: Reuben Thomas <rrt@sc3d.org>
    bebarino committed Oct 29, 2009
Commits on Oct 23, 2009
  1. Merge branch 'maint-1.6.2'

    * maint-1.6.2:
      Fix crashes when files cannot be opened for reading/writing
      setup: remove genversion.pyc too
    
    Conflicts:
    	sonata/artwork.py
    	sonata/config.py
    	sonata/info.py
    bebarino committed Oct 23, 2009
  2. Fix crashes when files cannot be opened for reading/writing

    Previously, we wouldn't catch IOError's and OSError's when a file
    couldn't be opened for reading or writing. Fix this by surrounding those
    locations in try-except clauses and use the 'with' syntax to properly
    close files when errors occur.
    
    This resolves issues for users with a read-only home or otherwise
    read-only directories. Sadly, the artwork code downloads images directly
    to disk, and if the file cannot be opened there is no artwork shown.
    Fixing this is a larger issue we can resolve later.
    
    Fixes: #16355
    bebarino committed Oct 22, 2009
Commits on Oct 20, 2009
  1. setup: remove genversion.pyc too

    If a leftover genversion.pyc is still existant from a previous build, it
    will cause the version number to be incorrect. Delete it after
    installing.
    bebarino committed Oct 20, 2009
  2. Merge branch 'maint-1.6.2'

    * maint-1.6.2:
      translations: add Korean translation
      POTFILES: only include files with actual translatable strings
      translations: update TRANSLATORS file and remove messages.po
      setup: generate mo files better
      translations: update Slovak translations
      main: make ctrl-w withdraw app when withdraw app config set
      Fix bad calculation of played song time for audioscrobbling.
    bebarino committed Oct 20, 2009
  3. Merge branch 'jb/ko-translation' into maint-1.6.2

    * jb/ko-translation:
      translations: add Korean translation
    bebarino committed Oct 20, 2009
  4. translations: add Korean translation

    Jaesung BANG committed with bebarino Oct 20, 2009
  5. Merge branch 'rh/sk-po-update' into maint-1.6.2

    * rh/sk-po-update:
      translations: update Slovak translations
    bebarino committed Oct 20, 2009
  6. Merge branch 'sb/translation-cleanup' into maint-1.6.2

    * sb/translation-cleanup:
      POTFILES: only include files with actual translatable strings
      translations: update TRANSLATORS file and remove messages.po
      setup: generate mo files better
    bebarino committed Oct 20, 2009
  7. POTFILES: only include files with actual translatable strings

    We shouldn't include files in POTFILES.in that don't actually have
    translatable strings because they just waste time generating templates
    and updating po files.
    bebarino committed Oct 20, 2009
  8. translations: update TRANSLATORS file and remove messages.po

    Now that we use git be a little more specific about how to add new
    translations. In particular, we don't want to maintain a messages.po
    file, as it should be generated by translators for any release they
    want to target. Also add a section on updating po files.
    bebarino committed Oct 20, 2009
  9. setup: generate mo files better

    The po files used to be manually listed leading to problems where po
    files are added or removed from the po/ directory. Instead of hardcoding
    the po files, list the directory and grab any .po file, using the names
    of the files as the language.
    bebarino committed Oct 20, 2009
  10. translations: update Slovak translations

    Robert Hartl committed with bebarino Oct 20, 2009
Commits on Oct 19, 2009
  1. Merge branch 'sb/withdraw-on-ctrl-w' into maint-1.6.2

    * sb/withdraw-on-ctrl-w:
      main: make ctrl-w withdraw app when withdraw app config set
    bebarino committed Oct 19, 2009
  2. main: make ctrl-w withdraw app when withdraw app config set

    If the config option to withdraw the app on close is set, ctrl-w would
    close the entire program when it should really just withdraw the app.
    Fix by not forcing the application to close on ctrl-w.
    
    Fixes: #16354
    bebarino committed Oct 19, 2009
  3. Merge branch 'jm/fix-scrobbler' into maint-1.6.2

    * jm/fix-scrobbler:
      Fix bad calculation of played song time for audioscrobbling.
    bebarino committed Oct 19, 2009
  4. Fix bad calculation of played song time for audioscrobbling.

    Sonata calls iterate() at 0.5s intervals when playing a song, in which
    it calls handle_change_status() if the status has changed, which calls
    scrobbler's handle_change_status(), which updates the played time using
    its scrob_time_now attribute. iterate() then calls scrobbler's
    iterate(), which updates that attribute to the current time.
    
    As a result, it can only increment 0.5s per status update. The status
    usually doesn't update that often, and thus the counted play time lags
    significantly behind the actual play time. In particular, if the update
    interval exceeds 1s, scrobbler will never post the song after a normal
    play.  This fixes this by counting play time entirely in scrobbler's
    handle_change_status().
    John McNeil committed with bebarino Oct 11, 2009
Commits on Oct 15, 2009
  1. Merge branch 'maint-1.6.2'

    Conflicts:
    	sonata/artwork.py
    	sonata/info.py
    bebarino committed Oct 15, 2009
  2. Merge branch 'sb/big-artwork-first' into maint-1.6.2

    * sb/big-artwork-first:
      rhapsody: download big artwork when requesting single image
    bebarino committed Oct 15, 2009
  3. Merge branch 'wb/lyricwiki-redirect' into maint-1.6.2

    * wb/lyricwiki-redirect:
      Improve lyricwiki REDIRECT handling
    bebarino committed Oct 15, 2009
  4. Improve lyricwiki REDIRECT handling

    This patch improves lyricwiki "#REDIRECT" handling:
    
     - detect redirect field independent of case and whitespace
    
     - after redirection, ensure that variable "content" is in same semantic state after
       redirection as without redirection
    
    [sb: backported to maint-1.6.2]
    wmzb committed with bebarino Oct 15, 2009
  5. rhapsody: download big artwork when requesting single image

    Previously, the first artwork image listed by rhapsody would be
    downloaded usually resulting in a small 70x70 image. Download the larger
    170x170 image (usually the last image) instead because the most frequent
    user of the artwork is the currently playing icon.
    
    Reported-by: Joschka Thurner <joschka.thurner@googlemail.com>
    bebarino committed Oct 15, 2009
Commits on Oct 14, 2009
Commits on Oct 3, 2009
  1. Merge branch 'maint-1.6.2'

    * maint-1.6.2:
      main: fix centering of current song in current playlist
      remove website from master
      add a .gitignore
      version: migrate to git version generation
      info: fix some merge issues
    
    Conflicts:
    	sonata/cli.py
    	sonata/info.py
    bebarino committed Oct 3, 2009
  2. main: fix centering of current song in current playlist

    Previously, the current song would be centered in the current playlist
    if the file is different than the previous song's file. It's possible
    for duplicate songs to be present in the current playlist, and thus
    this test would fail. Instead of using the file, use the song's
    id which should be unique within the playlist.
    bebarino committed Sep 23, 2009
Commits on Oct 1, 2009
  1. remove website from master

    I messed this up. The website sources were split off to the website
    branch, but I forgot to remove the website sources from the master
    branch. Since I've already published, and others have already cloned
    we get to live with this.
    bebarino committed Sep 22, 2009
  2. add a .gitignore

    bebarino committed Sep 22, 2009
  3. version: migrate to git version generation

    Migrate the svn version generation code to git. In the process, simplify
    the logic so the first try is the build generated file. If that
    fails, try the git describe method and finally fallback to the default
    version.
    bebarino committed Sep 22, 2009
  4. info: fix some merge issues

    I messed up some of the cherry-picking in this branch but luckily I
    didn't mess up the cherry-picking for the release. Fix some stupid
    mistakes introduced when publishing in git.
    bebarino committed Sep 30, 2009
Commits on Sep 22, 2009
  1. Merge branch 'maint-1.6.2'

    Pickup changelog and throw away backported patches
    Conflicts:
    	CHANGELOG
    	sonata/artwork.py
    	sonata/info.py
    	sonata/main.py
    bebarino committed Sep 22, 2009