Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Oct 29, 2009
  1. @bebarino

    Merge branch 'maint-1.6.2'

    bebarino authored
    * maint-1.6.2:
      library: don't list albums with multiple discs multiple times
  2. @bebarino

    Merge branch 'sb/album-multiple-discs' into maint-1.6.2

    bebarino authored
    * sb/album-multiple-discs:
      library: don't list albums with multiple discs multiple times
  3. @bebarino

    library: don't list albums with multiple discs multiple times

    bebarino authored
    If a user has a music directory where an album has multiple directories
    for each disc, we would wrongly list that album multiple times in the
    album view. This is because when we remove duplicate album listings, the
    differing paths lead us to believe the albums are not the same. Fix this
    by ignoring the path of the music files so when we remove the duplicates
    we are left with just one album instead of multiple ones.
    
    Fixes: #16368
    Tested-by: Reuben Thomas <rrt@sc3d.org>
Commits on Oct 23, 2009
  1. @bebarino

    Merge branch 'maint-1.6.2'

    bebarino authored
    * maint-1.6.2:
      Fix crashes when files cannot be opened for reading/writing
      setup: remove genversion.pyc too
    
    Conflicts:
    	sonata/artwork.py
    	sonata/config.py
    	sonata/info.py
  2. @bebarino
  3. @bebarino

    Fix crashes when files cannot be opened for reading/writing

    bebarino authored
    Previously, we wouldn't catch IOError's and OSError's when a file
    couldn't be opened for reading or writing. Fix this by surrounding those
    locations in try-except clauses and use the 'with' syntax to properly
    close files when errors occur.
    
    This resolves issues for users with a read-only home or otherwise
    read-only directories. Sadly, the artwork code downloads images directly
    to disk, and if the file cannot be opened there is no artwork shown.
    Fixing this is a larger issue we can resolve later.
    
    Fixes: #16355
Commits on Oct 20, 2009
  1. @bebarino

    setup: remove genversion.pyc too

    bebarino authored
    If a leftover genversion.pyc is still existant from a previous build, it
    will cause the version number to be incorrect. Delete it after
    installing.
  2. @bebarino

    Merge branch 'maint-1.6.2'

    bebarino authored
    * maint-1.6.2:
      translations: add Korean translation
      POTFILES: only include files with actual translatable strings
      translations: update TRANSLATORS file and remove messages.po
      setup: generate mo files better
      translations: update Slovak translations
      main: make ctrl-w withdraw app when withdraw app config set
      Fix bad calculation of played song time for audioscrobbling.
  3. @bebarino

    Merge branch 'jb/ko-translation' into maint-1.6.2

    bebarino authored
    * jb/ko-translation:
      translations: add Korean translation
  4. @bebarino

    translations: add Korean translation

    Jaesung BANG authored bebarino committed
  5. @bebarino

    Merge branch 'rh/sk-po-update' into maint-1.6.2

    bebarino authored
    * rh/sk-po-update:
      translations: update Slovak translations
  6. @bebarino

    Merge branch 'sb/translation-cleanup' into maint-1.6.2

    bebarino authored
    * sb/translation-cleanup:
      POTFILES: only include files with actual translatable strings
      translations: update TRANSLATORS file and remove messages.po
      setup: generate mo files better
  7. @bebarino

    POTFILES: only include files with actual translatable strings

    bebarino authored
    We shouldn't include files in POTFILES.in that don't actually have
    translatable strings because they just waste time generating templates
    and updating po files.
  8. @bebarino

    translations: update TRANSLATORS file and remove messages.po

    bebarino authored
    Now that we use git be a little more specific about how to add new
    translations. In particular, we don't want to maintain a messages.po
    file, as it should be generated by translators for any release they
    want to target. Also add a section on updating po files.
  9. @bebarino

    setup: generate mo files better

    bebarino authored
    The po files used to be manually listed leading to problems where po
    files are added or removed from the po/ directory. Instead of hardcoding
    the po files, list the directory and grab any .po file, using the names
    of the files as the language.
  10. @bebarino

    translations: update Slovak translations

    Robert Hartl authored bebarino committed
Commits on Oct 19, 2009
  1. @bebarino

    Merge branch 'sb/withdraw-on-ctrl-w' into maint-1.6.2

    bebarino authored
    * sb/withdraw-on-ctrl-w:
      main: make ctrl-w withdraw app when withdraw app config set
  2. @bebarino

    main: make ctrl-w withdraw app when withdraw app config set

    bebarino authored
    If the config option to withdraw the app on close is set, ctrl-w would
    close the entire program when it should really just withdraw the app.
    Fix by not forcing the application to close on ctrl-w.
    
    Fixes: #16354
  3. @bebarino

    Merge branch 'jm/fix-scrobbler' into maint-1.6.2

    bebarino authored
    * jm/fix-scrobbler:
      Fix bad calculation of played song time for audioscrobbling.
  4. @bebarino

    Fix bad calculation of played song time for audioscrobbling.

    John McNeil authored bebarino committed
    Sonata calls iterate() at 0.5s intervals when playing a song, in which
    it calls handle_change_status() if the status has changed, which calls
    scrobbler's handle_change_status(), which updates the played time using
    its scrob_time_now attribute. iterate() then calls scrobbler's
    iterate(), which updates that attribute to the current time.
    
    As a result, it can only increment 0.5s per status update. The status
    usually doesn't update that often, and thus the counted play time lags
    significantly behind the actual play time. In particular, if the update
    interval exceeds 1s, scrobbler will never post the song after a normal
    play.  This fixes this by counting play time entirely in scrobbler's
    handle_change_status().
Commits on Oct 15, 2009
  1. @bebarino

    Merge branch 'maint-1.6.2'

    bebarino authored
    Conflicts:
    	sonata/artwork.py
    	sonata/info.py
  2. @bebarino

    Merge branch 'sb/big-artwork-first' into maint-1.6.2

    bebarino authored
    * sb/big-artwork-first:
      rhapsody: download big artwork when requesting single image
  3. @bebarino

    Merge branch 'wb/lyricwiki-redirect' into maint-1.6.2

    bebarino authored
    * wb/lyricwiki-redirect:
      Improve lyricwiki REDIRECT handling
  4. @wmzb @bebarino

    Improve lyricwiki REDIRECT handling

    wmzb authored bebarino committed
    This patch improves lyricwiki "#REDIRECT" handling:
    
     - detect redirect field independent of case and whitespace
    
     - after redirection, ensure that variable "content" is in same semantic state after
       redirection as without redirection
    
    [sb: backported to maint-1.6.2]
  5. @bebarino

    rhapsody: download big artwork when requesting single image

    bebarino authored
    Previously, the first artwork image listed by rhapsody would be
    downloaded usually resulting in a small 70x70 image. Download the larger
    170x170 image (usually the last image) instead because the most frequent
    user of the artwork is the currently playing icon.
    
    Reported-by: Joschka Thurner <joschka.thurner@googlemail.com>
Commits on Oct 14, 2009
  1. @tuukka @bebarino

    remove bogus musicbrainz id from scrobbling

    tuukka authored bebarino committed
Commits on Oct 3, 2009
  1. @bebarino

    Merge branch 'maint-1.6.2'

    bebarino authored
    * maint-1.6.2:
      main: fix centering of current song in current playlist
      remove website from master
      add a .gitignore
      version: migrate to git version generation
      info: fix some merge issues
    
    Conflicts:
    	sonata/cli.py
    	sonata/info.py
  2. @bebarino

    main: fix centering of current song in current playlist

    bebarino authored
    Previously, the current song would be centered in the current playlist
    if the file is different than the previous song's file. It's possible
    for duplicate songs to be present in the current playlist, and thus
    this test would fail. Instead of using the file, use the song's
    id which should be unique within the playlist.
Commits on Oct 1, 2009
  1. @bebarino
  2. @bebarino

    remove website from master

    bebarino authored
    I messed this up. The website sources were split off to the website
    branch, but I forgot to remove the website sources from the master
    branch. Since I've already published, and others have already cloned
    we get to live with this.
  3. @bebarino

    add a .gitignore

    bebarino authored
  4. @bebarino

    version: migrate to git version generation

    bebarino authored
    Migrate the svn version generation code to git. In the process, simplify
    the logic so the first try is the build generated file. If that
    fails, try the git describe method and finally fallback to the default
    version.
  5. @bebarino

    info: fix some merge issues

    bebarino authored
    I messed up some of the cherry-picking in this branch but luckily I
    didn't mess up the cherry-picking for the release. Fix some stupid
    mistakes introduced when publishing in git.
Commits on Sep 22, 2009
  1. @master @bebarino

    misc: add support for Chromium browser

    master authored bebarino committed
  2. @bebarino

    Merge branch 'maint-1.6.2'

    bebarino authored
    Pickup changelog and throw away backported patches
    Conflicts:
    	CHANGELOG
    	sonata/artwork.py
    	sonata/info.py
    	sonata/main.py
Something went wrong with that request. Please try again.