Fix FilePart length calculation for Ruby 1.9 when filename contains multibyte characters #21

Merged
merged 2 commits into from Dec 21, 2013

Conversation

Projects
None yet
2 participants
Contributor

hexfet commented Nov 14, 2012

Applicable RFCs (http://en.wikipedia.org/wiki/MIME#Encoded-Word,
http://stackoverflow.com/questions/1361604) indicate only ASCII8BIT is allowed
in headers and suggest encoding options, but Chrome and Firefox put multibyte
characters in the header and the Rails stack handles it correctly, so just
fix the length.

The test is written the way it is to avoid embedding multibyte characters in the source file.

hexfet added some commits Nov 14, 2012

Fix FilePart length calculation for Ruby 1.9 when filename contains m…
…ultibyte

characters.

Applicable RFCs (http://en.wikipedia.org/wiki/MIME#Encoded-Word,
http://stackoverflow.com/questions/1361604) indicate only ASCII8BIT is allowed
in headers and suggest encoding options, but Chrome and Firefox put multibyte
characters in the header and the Rails stack handles it correctly, so ... just
fix the length.

nicksieger added a commit that referenced this pull request Dec 21, 2013

Merge pull request #21 from hexfet/master
Fix FilePart length calculation for Ruby 1.9 when filename contains multibyte characters

@nicksieger nicksieger merged commit b940e62 into nicksieger:master Dec 21, 2013

Owner

nicksieger commented Dec 21, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment