Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old notifications #8

Closed
rullzer opened this Issue Oct 17, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@rullzer
Copy link
Collaborator

commented Oct 17, 2018

When a token is deleted (in the backgroundjob). The notification should be cleared as well.

@rullzer rullzer added this to the 1.0.0 milestone Oct 17, 2018

@rullzer rullzer self-assigned this Oct 17, 2018

rullzer added a commit that referenced this issue Oct 18, 2018

Abstract away with token manager
Fixes #8

Introduces a tokenmanager. This adds a little logic between the dump
TokenMapper and the caller. It will cleanup the notifications if needed
and check if a token is still valid (10 minutes).

It also handles the removing of all the old tokens by cleaning up their
notifications.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer added a commit that referenced this issue Oct 19, 2018

Abstract away with token manager
Fixes #8

Introduces a tokenmanager. This adds a little logic between the dump
TokenMapper and the caller. It will cleanup the notifications if needed
and check if a token is still valid (10 minutes).

It also handles the removing of all the old tokens by cleaning up their
notifications.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer closed this in #21 Oct 19, 2018

rullzer added a commit that referenced this issue Oct 19, 2018

Abstract away with token manager
Fixes #8

Introduces a tokenmanager. This adds a little logic between the dump
TokenMapper and the caller. It will cleanup the notifications if needed
and check if a token is still valid (10 minutes).

It also handles the removing of all the old tokens by cleaning up their
notifications.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.