New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect selector for keydown event handler #17

Closed
swissspidy opened this Issue Mar 24, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@swissspidy

swissspidy commented Mar 24, 2017

Inside Accordion.prototype.initEvents, the selector being used is this.options.panelSelector.

However, the correct one would be this.options.panelsSelector (panels vs. panel).

See

panelsSelector: '.js-accordion__panel',
and
this.$wrapper.on('keydown', this.options.panelSelector, $.proxy(this.keydownPanelEventHandler, this));

@nico3333fr nico3333fr self-assigned this Mar 24, 2017

@nico3333fr nico3333fr added the bug label Mar 24, 2017

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Mar 24, 2017

Owner

Correct, this is fixed, and this allowed me to find another bug.

Thank you 👍

Owner

nico3333fr commented Mar 24, 2017

Correct, this is fixed, and this allowed me to find another bug.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment