New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$activated is not defined #7

Closed
zomars opened this Issue Aug 22, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@zomars
Contributor

zomars commented Aug 22, 2016

I'm getting the following error:

Uncaught ReferenceError: $activated is not defined

And it points me to this line: jquery-accessible-carrousel-aria.js:464

I'm using out of the box jQuery v2.2.4

@nico3333fr nico3333fr self-assigned this Aug 22, 2016

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Aug 22, 2016

Owner

Hi @zomars ,

I've tested with the demo page with jQuery 2.2.4, I didn't get any problem. :-\

Do you have an example on a page that I could have a look ? This bug is strange.

Kind regards,
Nicolas

Owner

nico3333fr commented Aug 22, 2016

Hi @zomars ,

I've tested with the demo page with jQuery 2.2.4, I didn't get any problem. :-\

Do you have an example on a page that I could have a look ? This bug is strange.

Kind regards,
Nicolas

zomars added a commit to zomars/jquery-accessible-carrousel-aria that referenced this issue Aug 22, 2016

@zomars

This comment has been minimized.

Show comment
Hide comment
@zomars

zomars Aug 22, 2016

Contributor

This only happens when trying to use the next and previous buttons, the pull request (#8) I made solves it.

Contributor

zomars commented Aug 22, 2016

This only happens when trying to use the next and previous buttons, the pull request (#8) I made solves it.

@nico3333fr nico3333fr closed this in #8 Aug 22, 2016

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Aug 22, 2016

Owner

Great work, thanks a lot for pointing out this mistake I made! 👍

Owner

nico3333fr commented Aug 22, 2016

Great work, thanks a lot for pointing out this mistake I made! 👍

@nico3333fr nico3333fr added the bug label Aug 22, 2016

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Aug 22, 2016

Owner

Thanks again, I've published your update to NPM/Bower and in the demo page: http://a11y.nicolas-hoffmann.net/carrousel/

Owner

nico3333fr commented Aug 22, 2016

Thanks again, I've published your update to NPM/Bower and in the demo page: http://a11y.nicolas-hoffmann.net/carrousel/

@zomars

This comment has been minimized.

Show comment
Hide comment
@zomars

zomars Aug 22, 2016

Contributor

Thanks a lot! I'm glad I could help. 💪

Contributor

zomars commented Aug 22, 2016

Thanks a lot! I'm glad I could help. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment