Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'open' attribute to dialog element #3

Merged
merged 1 commit into from Nov 2, 2016

Conversation

Projects
None yet
2 participants
@samrichca
Copy link
Contributor

commented Nov 1, 2016

https://developer.mozilla.org/en/docs/Web/HTML/Element/dialog

The dialog element should have the attribute 'open'. Chrome supports this element but puts display: none on the dialog if it's not 'open'.

Add 'open' attribute to dialog element
https://developer.mozilla.org/en/docs/Web/HTML/Element/dialog

The dialog element should have the attribute 'open'. Chrome supports this element but puts display: none on the dialog if it's not 'open'.

@nico3333fr nico3333fr self-assigned this Nov 2, 2016

@nico3333fr nico3333fr merged commit 39475c1 into nico3333fr:master Nov 2, 2016

@nico3333fr

This comment has been minimized.

Copy link
Owner

commented Nov 2, 2016

Hi @samrichca : thanks for your suggestion, it is merged 👍

nico3333fr added a commit to nico3333fr/jquery-accessible-modal-window-aria that referenced this pull request Nov 2, 2016

Aymkdn added a commit to Aymkdn/picoModal-Accessible that referenced this pull request Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.