Define your own classname only once #18

Closed
rastersysteme opened this Issue Mar 1, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@rastersysteme

If you want to set your own classname for $to_expand, you have to set it twice at the moment:

In line 16 you define your var like this: $to_expand = $('.js-to_expand').
In line 28 you don’t use this var but instead you use the classname again: $to_expand = $this.next(".js-to_expand").

As expected it would be nice to define your own classname only once inside the vars at the top.

@nico3333fr nico3333fr closed this in d703cdb Mar 3, 2017

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Mar 3, 2017

Owner

Hi @rastersysteme

you are right. For the moment, I've removed a selector in d703cdb but I will do better in a next release with a huge rewrite to be more configurable.

Thanks a lot for pointing this out ;)

Owner

nico3333fr commented Mar 3, 2017

Hi @rastersysteme

you are right. For the moment, I've removed a selector in d703cdb but I will do better in a next release with a huge rewrite to be more configurable.

Thanks a lot for pointing this out ;)

@nico3333fr nico3333fr self-assigned this Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment