Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define your own classname only once #18

Closed
rastersysteme opened this issue Mar 1, 2017 · 1 comment
Closed

Define your own classname only once #18

rastersysteme opened this issue Mar 1, 2017 · 1 comment
Assignees
Labels

Comments

@rastersysteme
Copy link

@rastersysteme rastersysteme commented Mar 1, 2017

If you want to set your own classname for $to_expand, you have to set it twice at the moment:

In line 16 you define your var like this: $to_expand = $('.js-to_expand').
In line 28 you don’t use this var but instead you use the classname again: $to_expand = $this.next(".js-to_expand").

As expected it would be nice to define your own classname only once inside the vars at the top.

@nico3333fr nico3333fr closed this in d703cdb Mar 3, 2017
@nico3333fr
Copy link
Owner

@nico3333fr nico3333fr commented Mar 3, 2017

Hi @rastersysteme

you are right. For the moment, I've removed a selector in d703cdb but I will do better in a next release with a huge rewrite to be more configurable.

Thanks a lot for pointing this out ;)

@nico3333fr nico3333fr self-assigned this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.