New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught ReferenceError: $close is not defined #16

Closed
pepemiyashiro opened this Issue Oct 20, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@pepemiyashiro

pepemiyashiro commented Oct 20, 2016

Hello,

I found this error log.
And this is related to the variables declaration on line: 184

var $this = $(this),
      $js_modal = $('#js-modal'),
      focusedItem = $( document.activeElement ),
      in_jsmodal = focusedItem.parents('#js-modal').length ? true : false;
     $close = $('#js-modal-close');

I found that the in_jsmodal assigment end in a semicolon, and it should be a comma.

Shold be like this:

var $this = $(this),
      $js_modal = $('#js-modal'),
      focusedItem = $( document.activeElement ),
      in_jsmodal = focusedItem.parents('#js-modal').length ? true : false,
     $close = $('#js-modal-close');

Hope it helps.

@nico3333fr nico3333fr self-assigned this Oct 21, 2016

@nico3333fr nico3333fr added the bug label Oct 21, 2016

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented Oct 21, 2016

Hi @pepemiyashiro

thanks a lot for pointing it out, I've fixed it.

Kind regards,
Nicolas

@pepemiyashiro

This comment has been minimized.

pepemiyashiro commented Oct 21, 2016

Hi @nico3333fr You are welcome. And thanks for the nice modal plugin you have done.

Thanks you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment