New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslatable text in background modal #19

Closed
juliemoynat opened this Issue May 15, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@juliemoynat

juliemoynat commented May 15, 2017

Hi,

The text in the background modal in not translatable:
<span id="js-modal-overlay" class="simple-modal-overlay" title="Fermer" data-background-click="enabled"><span class="invisible">Close modal</span></span>

Could it be in a "data" attribute?

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented May 15, 2017

Hi,

you're right, it was missing, I've fixed it in last commit.

I've used the data-modal-close-text value.

Thanks for pointing it out 👍

@nico3333fr nico3333fr self-assigned this May 15, 2017

@nico3333fr nico3333fr added the bug label May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment