New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Text Inaccessible on iOS #21

Closed
mdparker26 opened this Issue Aug 16, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@mdparker26

mdparker26 commented Aug 16, 2017

Hi -

I've recently noticed a problem with the modals on https://a11y.nicolas-hoffmann.net/modal/ where the text is not read on iOS 10.3.3 devices when using Safari and VoiceOver.

For example, on the "First Simple Example" modal, the following is what appears:

Close (This is read)
Title (This is read)
Hello world! (This is not read)

Any idea what could be happening?

Thanks,
Michael

@nico3333fr nico3333fr self-assigned this Aug 16, 2017

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented Aug 17, 2017

Hi @mdparker26

thanks for this report, I asked @goetsu if he could reproduce it (I'm not using a mac), and he confirmed the bug. We are going to make some tests, to know if it is an iOS bug or if we can find a workaround to avoid it.

Thanks,
Nicolas

@nico3333fr nico3333fr added the bug label Aug 17, 2017

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented Aug 17, 2017

It seems that the problem is coming from the use of aria-modal="true" with role="dialog" .

While waiting for a perfect solution, I guess we will have to remove role="dialog", and separate cases.

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented Aug 17, 2017

Could you test on this example ? https://a11y.nicolas-hoffmann.net/modal/

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented Aug 17, 2017

It seems that the fix worked, could you confirm ?

@mdparker26

This comment has been minimized.

mdparker26 commented Aug 17, 2017

@mdparker26

This comment has been minimized.

mdparker26 commented Aug 17, 2017

@nico3333fr

This comment has been minimized.

Owner

nico3333fr commented Aug 18, 2017

Last commit has fixed the issue on VO.

Thanks for pointing out this bug. 👍

For the "close it", it is more an overlay for users using the mouse, not really a link or button. Keyboard users should be trapped into the modal, when it is opened (focus is trapped even if the users tabulates from the URL bar).

nico3333fr added a commit to nico3333fr/jquery-accessible-dialog-tooltip-aria that referenced this issue Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment