New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable URL fragments? #18

Closed
dennisfrank opened this Issue Jun 27, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@dennisfrank
Copy link

dennisfrank commented Jun 27, 2017

Is it possible to disable URL fragments?

URL fragments can interfere with the back button. If you went through some tabs you need the the same amount of clicks/tabs to navigate to the previous page via the browser back button. Also, not every user understands URL fragments when copying URLs from the URL bar.

I can imagine that for some sites/pages it makes a lot of sense to utilize URL fragments on others not so much.

@nico3333fr

This comment has been minimized.

Copy link
Owner

nico3333fr commented Jun 29, 2017

Hi @dennisfrank

well, I have the issue for the moment that if the back button is used, the tabs are not updating themselves (I did not manage to find how setting up a "listener" for it), however the benefits are still more important than the problems, so that is why I kept them. :)

Well, this might be an option to add.

Thanks for the idea,
Nicolas

@nico3333fr nico3333fr self-assigned this Jun 29, 2017

@nico3333fr

This comment has been minimized.

Copy link
Owner

nico3333fr commented Sep 21, 2017

Hi @dennisfrank

the option has been added in last commits, and in the doc.

I hope you don't mind, I've mentionned your request on the plugin page https://a11y.nicolas-hoffmann.net/tabs/

Thanks for the suggestion again 👍

@dennisfrank

This comment has been minimized.

Copy link

dennisfrank commented Sep 21, 2017

@nico3333fr Awesome! Thank you! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment