New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvement (single AST traversal run) #80
Performance improvement (single AST traversal run) #80
Conversation
06a19de
to
6b19bde
Compare
6b19bde
to
d883dd5
Compare
Co-Authored-By: Nicolas Carlo <nicolascarlo.espeon@gmail.com>
Co-Authored-By: Nicolas Carlo <nicolascarlo.espeon@gmail.com>
@nicoespeon I'll check the other suggestions tomorrow (March 3rd, UTC+1 timezone). |
@visusnet also, I'll be able to give you a hand on this if you need to. Just let me know ;-) |
@nicoespeon My team and I are on a team event, i.e. I won‘t be able to do something today. I‘m not sure yet how much there is to do. I‘ll come back to your offer if necessary. Thank you. :) |
@visusnet no worries. I think I should be able to tackle my comments on Thursday morning (EST time) 😃 Since I agree with the direction of the PR, my goal is to get this merged while keeping Enjoy your team event and thanks for your precious help! |
Soooo, I didn't have time to work on this today. I won't have time to do so this week-end and next week neither (conference incoming). That's fine, there's no hurry 👍 |
@nicoespeon I have updated this PR with most of your suggestions. I have rebased the other PRs. If you have more suggestions, feel free to change them directly. This might be more efficient than telling me minor things which I will just click to have them committed anyway. I have given you access to my fork. Have a nice conference week and give me a heads up in case you'll be at a European (especially in Germany) conference. I feel the urge to buy you a beer. |
Confirmed it works!
It's a union type issue. Path is of type `NodePath<Node>` by default, whereas a visitor expects `NodePath<File>` sometimes. At runtime it should be OK. If it's not, at least it won't crash (it will fail silently).
This is a continuation of #77.
Please use #79 for discussion.