Consistently use new-style classes #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, yeah. coming from Python 3 i missed this. is it also a good practice for mixin classes? |
|
I think so, otherwise you will be mixing old-style and new-style classes. And as far as i know in Python 3 all classes behave like new-style classes which is another good reason for doing this, so we don't have different behaviour in Python 2. |
nicolaiarocci
approved these changes
Sep 16, 2016
nicolaiarocci
added a commit
that referenced
this pull request
Sep 21, 2016
|
Merged with bacce0a Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use new-style classes wherever possible. There were still four classes not inheriting
objectwhich will lead to confusion when subclassing them (and probably more subtle issues). For example right now you can usesuperin a subclass ofValidator, but not in a subclass ofBasicErrorHandler.