On Tue, Apr 21, 11:19:00 -0500, John Goerzen wrote: > I think the one loss of functionality we have here is that it doesn't > check if a given account has already been listed before adding to the > list. Should be a simple tweak. If you could tweak that and test, I'd > apply a new patch. Good catch. I attach an updated patch which I've tested and it appears to work fine, including not syncing two accounts twice. Thanks, -- Jonny Lamb, UK email@example.com From 7f348ee116bba64f7330e28d4e7b2c015910a890 Mon Sep 17 00:00:00 2001 From: Jonny Lamb <firstname.lastname@example.org> Date: Tue, 05 May 2009 20:45:17 +0100 Subject: [PATCH] Respect order of general.accounts config setting. This makes the order of account synchronisation the same as the order of the general.accounts setting by using a list instead of a dict, which was actually pointless as the value of each dict item was never even looked at. Signed-off-by: Jonny Lamb <email@example.com>
Patch from Eric Dorland Closes: #470875 From: Wouter Verhelst Subject: kerberos authentication works only the first time Date: Fri, 14 Mar 2008 09:28:37 +0100 Package: offlineimap Version: 5.99.8 Severity: normal Hi, I have the "autorefresh" configuration option specified in my .offlineimaprc, and am now using the kerberos authentication. However, this kerberos authentication seems to work only the first time offlineimap tries to fetch mails. The next time, it fails with this output: Thread 'Account sync Test' terminated with exception: Traceback (most recent call last): File "/var/lib/python-support/python2.4/offlineimap/threadutil.py", line 153, in run Thread.run(self) File "/usr/lib/python2.4/threading.py", line 422, in run self.__target(*self.__args, **self.__kwargs) File "/var/lib/python-support/python2.4/offlineimap/accounts.py", line 119, in syncrunner self.sync() File "/var/lib/python-support/python2.4/offlineimap/accounts.py", line 148, in sync remoterepos.syncfoldersto(localrepos, [statusrepos]) File "/var/lib/python-support/python2.4/offlineimap/repository/Base.py", line 135, in syncfoldersto srcfolders = src.getfolders() File "/var/lib/python-support/python2.4/offlineimap/repository/IMAP.py", line 192, in getfolders listresult = imapobj.list(directory = self.imapserver.reference) File "/usr/lib/python2.4/imaplib.py", line 469, in list typ, dat = self._simple_command(name, directory, pattern) File "/usr/lib/python2.4/imaplib.py", line 1028, in _simple_command return self._command_complete(name, self._command(name, *args)) File "/usr/lib/python2.4/imaplib.py", line 787, in _command raise self.error( error: command LIST illegal in state NONAUTH
Paul Hinze <firstname.lastname@example.org> on 2008-12-22 at 19:16: > I did a bit of debugging and asking around in #python and it turns out > that because Maildir.py uses a conditional import of md5 from either > hashlib or the md5 module, the md5.new() call is not always correct. > The attached patch should fix this problem. Thanks to Daniel Rall for pointing out that the attachment got stripped off my last message. Patch follows. Paul ---- From e01fdfbf62c61c31b514e826e6cc00fb98d88808 Mon Sep 17 00:00:00 2001 From: Paul Hinze <email@example.com> Date: Mon, 22 Dec 2008 18:42:44 -0600 Subject: [PATCH] Fixing md5 import when hashlib is available Thanks to habnabit and Rhamphoryncus in #python for help debugging
Here's the way I'd like to use offlineimap on my laptop: 1. Have a regular cron job running infrequently. The cron job checks to see if I'm online, plugged in, and that no other copy of offlineimap is running. If all of these conditions are satisfied, it runs offlineimap just once: "offlineimap -o -u Noninteractive.Quiet" 2. When I start up mutt, I do it by calling a wrapper script that delays until cron-started copies of offlineimap have finished, then starts offlineimap on its regular, stay-alive and keep checking schedule. When I quit mutt, the wrapper script tells offlineimap to stop. This way I get frequent regular checks while I have mutt running, but I don't waste my battery/cpu checking frequently for mail when I'm not interested in it. To make this work, though, it'd be nicer if it were easier to tell offlineimap, from the outside, things like "terminate cleanly now" and "when you've finished synching, then terminate instead of sleeping and synching again." OK, to put my money where my mouth is, I attach two patches against offlineimap 6.0.3. The first, "cleanup.patch", cleans up a few spots that tend to throw exceptions for me as offlineimap is exiting from a KeyboardInterrupt. The second adds signaling capabilities to offlineimap. * sending a SIGTERM tells offlineimap to terminate immediately but cleanly, just as if "q" had been pressed in the GUI interface * sending a SIGUSR1 tells every account to do a full sync asap: if it's sleeping, then wake up and do the sync now. If it's mid-sync, then re-synch any folders whose syncing has already been started or completed, and continue to synch the other, queued but not-yet-synched folders. * sending a SIGHUP tells every account to die as soon as it can (but not immediately: only after finishing any synch it's now engaged in) * sending a SIGUSR2 tells every account to do a full sync asap (as with SIGUSR1), then die It's tricky to mix signals with threads, but I think I've done this correctly. I've been using it now for a few weeks without any obvious problems. But I'm passing it on so that others can review the code and test it out on their systems. I developed the patch when I was running Python 2.5.2, but to my knowledge I don't use any Python 2.5-specific code. Now I'm using the patch with Python 2.6. Although I said "without any obvious problems," let me confess that I'm seeing offlineimap regularly choke when I do things like this: start up my offlineimap-wrapped copy of mutt, wait a while, put the machine to sleep (not sure if offlineimap is active in the background or idling), move to a different spot, wake the machine up again and it acquires a new network, sometimes a wired network instead of wifi. Offlineimap doesn't like that so much. I don't yet have any reason to think the problems here come from my patches. But I'm just acknowledging them, so that if others are able to use offlineimap without any difficulty in situations like I described, then maybe the fault is with my patches.
Frankly, the original code doesn't even make much sense, and moreover it's not forward compatible with python 2.6, and furthermore: DeprecationWarning: socket.ssl() is deprecated. So, this commit is just a temporary fix. Signed-off-by: Michael Witten <firstname.lastname@example.org>
Convert os.getpid() to a string before writing it to the pid file in order to avoid generating an empty pid file.