Added multiple inheritance feature #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2018 22:08
This changes have been made wrt nicolasdao#5 (comment)
Owner
|
Thank you @pankajparkar. Sorry to have taken an unreasonable amount of time to approve that pull request (which is BTW impeccable), we are very busy ATM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @rohitghatol, I extended a library to support a multiple inheritance. For the same I've added test cases for multiple inheritance. Also updated the readme.md file as well.
Major change that I made in the library is, I converted
inheritsproperty of an internal object to hold anArrayof inheritedtype(s), previously it was holding single inheritedtypeobject. Now irrespective what we're using (single/multiple inheritance), it will preserve inherited type in anArrayform insideinheritsproperty.Would you mind to review this pull request? Let me know if your thoughts on this.