$.ajax() uses deferreds & Deferred.success() is on completion or after

This means we can simplify the code here as it will get fired when the ajax request completes successfully or has *already* completed successfully!
nicolaslazartekaqui · Jul 18, 2011 · 4e2e742 · 4e2e742
1 parent 1f8daa8
commit 4e2e742
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 23 deletions.
diff --git a/data/html/sparkleshare.coffee b/data/html/sparkleshare.coffee
@@ -27,7 +27,7 @@
     @ajax
     @changes = {}
     @repo
-    
+
     constructor: (@repo = 'all') ->
       @update()
 
@@ -38,18 +38,10 @@
       "spec.json"
 
     render: ->
-      _compileTemplate = =>
+      @ajax.success =>
         template = Handlebars.compile $('#changeset-template').html()
         $('#content').html template @changes
 
-      ### 
-      * Either template it now, or when a pending ajax request finishes
-      ###
-      if @ajax?.readyState
-        @ajax.complete -> _compileTemplate()
-      else
-        _compileTemplate()
-
 
   changes = new ChangeSet
   changes.render()

diff --git a/data/html/sparkleshare.js b/data/html/sparkleshare.js
@@ -38,22 +38,11 @@
       return "spec.json";
     };
     ChangeSet.prototype.render = function() {
-      var _compileTemplate, _ref;
-      _compileTemplate = __bind(function() {
+      return this.ajax.success(__bind(function() {
         var template;
         template = Handlebars.compile($('#changeset-template').html());
         return $('#content').html(template(this.changes));
-      }, this);
-      /* 
-      * Either template it now, or when a pending ajax request finishes
-      */
-      if ((_ref = this.ajax) != null ? _ref.readyState : void 0) {
-        return this.ajax.complete(function() {
-          return _compileTemplate();
-        });
-      } else {
-        return _compileTemplate();
-      }
+      }, this));
     };
     return ChangeSet;
   })();