New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the shown name the real display name #51

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@PaulBrandt
Contributor

PaulBrandt commented Jul 19, 2018

display_name != username
The displayname is shown when u post something but currently this bot uses the username when impersonating.

Make the shown name the real display name
display_name != username
The displayname is shown when u post something but currently this bot uses the username when impersonating.
@aoberoi

This comment has been minimized.

Show comment
Hide comment
@aoberoi

aoberoi Jul 19, 2018

Collaborator

@PaulBrandt this looks reasonable to me, but just to be sure, have you tried running this to make sure it works?

Collaborator

aoberoi commented Jul 19, 2018

@PaulBrandt this looks reasonable to me, but just to be sure, have you tried running this to make sure it works?

@PaulBrandt

This comment has been minimized.

Show comment
Hide comment
@PaulBrandt

PaulBrandt Jul 20, 2018

Contributor

@aoberoi Tested today as working as intended.

Contributor

PaulBrandt commented Jul 20, 2018

@aoberoi Tested today as working as intended.

@aoberoi aoberoi merged commit 2622bf9 into nicolewhite:master Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment