Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make opening of Window's file manager (File Explorer) more generic #1004

Closed
redactedscribe opened this issue Feb 21, 2021 · 2 comments
Closed

Comments

@redactedscribe
Copy link
Contributor

Describe the solution you'd like

If I had to guess, Nicotine+ is explicitly calling explorer.exe and passing it arguments when performing an action such as Open Folder on a downloaded file. This will trigger File Explorer, but not all users may be using File Explorer as their Windows file management software.

Apparently there is a more generic way, at least, as much is hinted by this post on the forums of one File Explorer replacement:

... you may need to ask the software authors to change how they open folders, unless they have a reason for only using Explorer. In general, if they use ShellExecute on the folders, they just need to use a null verb and it will trigger the default file manager. Using "open" as the verb may do the wrong thing.

I'm not sure of the exact details as to how this works, but perhaps Nicotine+ could make this happen? The end result should be that nothing changes for File Explorer users, but those that use a replacement for it, will be able to use what they prefer.

Thanks.

@mathiascode
Copy link
Member

This is already the case if you clear the file manager command on older Nicotine+ installations. See
25e090d#diff-ff84e58d5fdb0ddcd333036f7a3725e44dd737541fc7c854029e2493fc4e9aa3
b28b459#diff-8638210f4ce1a12ae4a9fdcb692fadc1e666e692b08015cd3d9ad726d4760506

@redactedscribe
Copy link
Contributor Author

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants