Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of Gtk.Menu with Gio.Menu #1045

Closed
mathiascode opened this issue Apr 7, 2021 · 0 comments · Fixed by #1048
Closed

Replace usage of Gtk.Menu with Gio.Menu #1045

mathiascode opened this issue Apr 7, 2021 · 0 comments · Fixed by #1048
Labels
enhancement

Comments

@mathiascode
Copy link
Member

GtkMenu was removed in GTK4, which means we should start using menu models for our context menus. With menu models in place, we can keep using GtkMenu in GTK3, and easily switch to GtkPopoverMenu once we move to GTK4.

WIP branch from February, need to review and finish: https://github.com/mathiascode/nicotine-plus/commits/context-gmenu
Reference: https://gitlab.gnome.org/GNOME/gtk/-/blob/5710df685b0af9b7dd306dfba6c7e174e428950e/gtk/gtklabel.c#L5437-5515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Gio.Menu for context menus mathiascode/nicotine-plus
1 participant
@mathiascode